feat: Add the ability to disable test failures on report issue #146
Conversation
|
Awesome work, this is needed! I wonder if it'd be better if this behaviour was part of the existing IssueReporters array so that the existing method to disable things via: Would work as per the documentation This would mean in a testing context |
|
Sorry for leaving this hanging Luke! We're definitely down for the functionality but as @adamjcampbell mentioned it would be nice for it to be seamlessly integrated into existing APIs. We'll try to get around to thinking more about this soon. |
This patch moves the test reporting logic into a `default` reporter so that changing the reporters can influence tests. This is an alternate solution to #146.
|
@lukeredpath Thanks again for starting the discussion on this. I've pushed a PR for a more integrated solution here: #174 Going to close this out but glad you opened it to get things moving (albeit slowly!) 😄 |
3 participants
Adds the ability to disable the current default behaviour of triggering a test failure whenever reportIssue is called in a testing context with a new flag
TestContext.emitsFailureOnReportIssue. This value can be overridden for a single operation using thewithEmitsFailureOnReportIssue(_)helper function.Resolves #145.